Reapply "Load analyzers and generators in isolated ALCs in our OOP process" #75233
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
Can we get an ETW counter for every time we tear down / rebuild the assembly loader? That is one item we felt would've helped the initial investigation also seems like something we could get David to add as a critical counter for VS insertions. That would block other teams from introducing changes that caused us to reset load context too often. |
We can add counters for this. |
CyrusNajmabadi
force-pushed
the
revertRevert
branch
3 times, most recently
from
4efe410
to
846afc9
Compare
CyrusNajmabadi
force-pushed
the
revertRevert
branch
2 times, most recently
from
42fb81d
to
78612d6
Compare
|
draft while i wait on speedometer |
src/Workspaces/Core/Portable/Workspace/IsolatedAnalyzerReferenceSet.Core.cs
Outdated
Show resolved
Hide resolved
…ocess" This reverts commit a59061f.
CyrusNajmabadi
force-pushed
the
revertRevert
branch
from
e111cfe
to
3b37c24
Compare
CyrusNajmabadi
force-pushed
the
revertRevert
branch
from
3b37c24
to
d6af30f
Compare
|
@ToddGrun @jasonmalinowski this is ready for review. You just need to review the last two commits. |
| @@ -427,6 +427,8 @@ public bool TryFetch(LocalUserRegistryOptionPersister persister, OptionKey2 opti | |||
| {"dotnet_enable_diagnostics_in_source_generated_files_feature_flag", new FeatureFlagStorage(@"Roslyn.EnableDiagnosticsInSourceGeneratedFiles")}, | |||
| {"dotnet_source_generator_execution", new RoamingProfileStorage("TextEditor.Roslyn.Specific.SourceGeneratorExecution")}, | |||
| {"dotnet_source_generator_execution_balanced_feature_flag", new FeatureFlagStorage(@"Roslyn.SourceGeneratorExecutionBalanced")}, | |||
| {"dotnet_reload_changed_analyzer_references", new RoamingProfileStorage("TextEditor.Roslyn.Specific.ReloadChangedAnalyzerReferences")}, | |||
| {"dotnet_reload_changed_analyzer_references_feature_flag", new FeatureFlagStorage(@"Roslyn.ReloadChangedAnalyzerReferences")}, | |||
There was a problem hiding this comment.
these should be part of the next commit. oh well.
|
I'd prefer to hold on merging this until we get the assembly-binding things fixed up in main, as that appears to be causing ngen failures and jitting regressions. I'm not thinking this PR is responsible, but I just want to keep large variables out of the equation. |
| @@ -26,36 +26,36 @@ | |||
| <value>[base64 mime encoded string representing a byte array form of the .NET Framework object]</value> | |||
| <comment>This is a comment</comment> | |||
| </data> | |||
|
|
|||
| There are any number of "resheader" rows that contain simple | |||
|
|
|||
There was a problem hiding this comment.
What's up with the whitespace changes in this file?
There was a problem hiding this comment.
Constantly happens when I use the vs resx editor. No clue why.
src/Workspaces/Core/Portable/Workspace/IsolatedAnalyzerReferenceSet.Core.cs
Show resolved
Hide resolved
| @@ -272,6 +278,16 @@ private void DisplayInlineTypeHints_Unchecked(object sender, RoutedEventArgs e) | |||
| UpdateInlineHintsOptions(); | |||
| } | |||
|
|
|||
| private void RunCodeAnalysisInSeparateProcess_Checked(object sender, RoutedEventArgs e) | |||
There was a problem hiding this comment.
Does this fire only if the user changes it or if it's changed programmatically? The useful test would be to turn it off, restart VS, and see if we disable it when the options page loads the first time.
src/VisualStudio/VisualBasic/Impl/Options/AdvancedOptionPageControl.xaml.vb
Outdated
Show resolved
Hide resolved
src/Workspaces/Core/Portable/Workspace/IWorkspaceConfigurationService.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/Core/Portable/Workspace/IsolatedAnalyzerReferenceSet.Core.cs
Show resolved
Hide resolved
src/Workspaces/Core/Portable/Workspace/IsolatedAnalyzerReferenceSet.Core.cs
Show resolved
Hide resolved
|
@jasonmalinowski ptal. |
|
Got confirmation from infra that this can go in. |
This reverts commit a59061f.
Build: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=10279985&view=results
PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/580882
PR shows no regressions: https://devdiv.visualstudio.com/DevDiv/_apps/hub/ms-vseng.pit-vsengPerf.pit-hub?targetBuild=35325.126.dn-bot.240925.221550.580882&targetBranch=main&targetPerfBuildId=10281500&runGroup=PerfDDRITs64&baselineBuild=35325.104&baselineBranch=main
Build: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=10288337&view=results
PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/581245
Build: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10301230&view=results
PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/581245
Build (less directory enums): https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=10311649&view=results
PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/582181